Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hypershift api version to v1beta1 #1676

Conversation

jacobbaungard
Copy link
Contributor

v1alpha1 is no longer used, so we need to update to v1beta1 to avoid the metrics-collector from crashing.

Fixes: ACM-15628

v1alpha1 is no longer used, so we need to update to v1beta1 to avoid the
metrics-collector from crashing.

Fixes: ACM-15628

Signed-off-by: Jacob Baungard Hansen <[email protected]>
Copy link

sonarcloud bot commented Nov 20, 2024

@jacobbaungard
Copy link
Contributor Author

/cherry-pick main

@openshift-cherrypick-robot
Copy link
Collaborator

@jacobbaungard: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jacobbaungard
Copy link
Contributor Author

/test test-e2e

@jacobbaungard
Copy link
Contributor Author

/retest

@jacobbaungard
Copy link
Contributor Author

/test ci/prow/pr-image-mirror-endpoint-monitoring-operator

Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jacobbaungard,philipgough]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jacobbaungard
Copy link
Contributor Author

/override ci/prow/test-e2e

Overriding as this already passed e2e once.

Copy link

openshift-ci bot commented Nov 25, 2024

@jacobbaungard: Overrode contexts on behalf of jacobbaungard: ci/prow/test-e2e

In response to this:

/override ci/prow/test-e2e

Overriding as this already passed e2e once.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9820434 into stolostron:release-2.12 Nov 25, 2024
16 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@jacobbaungard: new pull request created: #1692

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants